You can leave out the "that" if you want.
"These are the days I'll treasure for life"
Either way works.
No, only 1. If you leave off "that", the chorus won't sound right:
These are the days I'll treasure for life - 1st line
Moments in time somehow captured in rhyme. - 3rd
See? It needs "that".